Actions

icon Post
text/html Subscribe
text/html Unsubscribe

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] fix domain error in particle test


  • To: Richard Guenther <rguenth@xxxxxxxxxxxxxxxxxxxxxxxxxxx>
  • Subject: Re: [PATCH] fix domain error in particle test
  • From: "Jeffrey D. Oldham" <oldham@xxxxxxxxxxxxxxxx>
  • Date: Wed, 01 Sep 2004 14:22:02 -0700

Richard Guenther wrote:

This patch fixes the last bug in particle tests to let MPI
parallelized versions pass on _one_ processor.

As update for the truly parallel testruns, the only ones failing
are now bctest3, spatial, uniform, destroy, particle_test1-4,
particle_bench1-4 and interpolate - all due
to the pAbort because "Cross-context particles not supported for MPI".

Ok?


2004Aug27  Richard Guenther <richard.guenther@xxxxxxxxxxxxxxxx>

	* src/Particles/tests/interpolate.cpp: initialize physical
	cell domain, not vertex domain.
------------------------------------------------------------------------

Index: interpolate.cpp
===================================================================
RCS file: /home/pooma/Repository/r2/src/Particles/tests/interpolate.cpp,v
retrieving revision 1.23
diff -u -u -r1.23 interpolate.cpp
--- interpolate.cpp	23 Aug 2004 18:44:17 -0000	1.23
+++ interpolate.cpp	27 Aug 2004 15:59:17 -0000
@@ -282,7 +282,7 @@
  // Initialize the field values

  tester.out() << "Initializing Field values ..." << std::endl;
-  Interval<PDim> dom = flayout.domain();
+  Interval<PDim> dom = electric.physicalDomain();
  for (int i = dom[0].first(); i <= dom[0].last(); ++i)
    for (int j = dom[1].first(); j <= dom[1].last(); ++j)
      electric(i,j) = Particles_t::PointType_t(i+j,i-j);
Yes, please commit this.

--
Jeffrey D. Oldham
oldham@xxxxxxxxxxxxxxxx