Actions

icon Post
text/html Subscribe
text/html Unsubscribe

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [vsipl++] [PATCH] #if out FFT tests when not config'd


  • To: "Nathan (Jasper) Myers" <ncm@xxxxxxxxxxxxxxxx>
  • Subject: Re: [vsipl++] [PATCH] #if out FFT tests when not config'd
  • From: Jules Bergmann <jules@xxxxxxxxxxxxxxxx>
  • Date: Mon, 26 Sep 2005 10:21:07 -0400

Nathan,

extdata-fft doesn't call vsip::Fft, it just demonstrates how one might use Ext_data to implement FFTs. It shouldn't need anything #if'd out.

Otherwise looks OK.

In the short term, we need to make sure that any attempt to use an unimplemented FFT function results in either a compilation error or an "unimplemented" exception.

In the long term, we need to implement a generic FFT that (a) works when no FFT library is provided and (b) fills in the gaps of whatever FFT library we're using.

				-- Jules




Nathan (Jasper) Myers wrote:
This patch adds #if blocks around tests that depend on FFT support,
pending addition of native FFT code to fill in lacunae.  It also adds
tests using double and complex<double>. Note this does not patch the tests in ref-impl.

OK to apply?