Actions

icon Post
text/html Subscribe
text/html Unsubscribe

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [vsipl++] [patch] load_view and save_view for tests


  • To: Jules Bergmann <jules@xxxxxxxxxxxxxxxx>
  • Subject: Re: [vsipl++] [patch] load_view and save_view for tests
  • From: Stefan Seefeld <stefan@xxxxxxxxxxxxxxxx>
  • Date: Fri, 30 Sep 2005 18:01:26 -0400

Jules,

shouldn't we try to consistently use <iostream> instead of <stdio.h> ?

Jules Bergmann wrote:

+   Load_view(char*                    filename,
+ 	    vsip::Domain<Dim> const& dom)
+     : data_  (new base_t[factor*dom.size()]),
+       block_ (dom, data_),
+       view_  (block_)
+   {
+     FILE*  fd;
+     size_t size = dom.size();
+ + if (!(fd = fopen(filename,"r")))

It might be better to use "rb" as the mode, just to avoid headaches if
we try to port the code to non-POSIX systems one day.

Regards,
		Stefan