Re: [vsipl++] [PATCH] Use IPP for Fir<>

[Jules Bergmann <jules@xxxxxxxxxxxxxxxx>]

Nathan (Jasper) Myers wrote:
> I have checked in the patch below.
>
> It makes vsip::Fir<> use IPP's FIR support where possible.  In practice,
> that means whenever block size and decimation are not relatively prime. 
> (IPP produces bad output when they are.  The IPP API seems to make it 
> impossible, so it amounts to an IPP documentation bug.)  Fir<> uses 
> the native C++ implementation for such cases.  They are probably rare 
> in real programs.
What happens when using a type not support by IPP (such as long double)? 
 Does the generic code get used?  Also, what happens when instantiating 
a FIR for a type we don't support (such as int)?
> The spec says the copy constructor Fir(Fir const&) is supposed to 
> be VSIP_NOTHROW, but it seems to me that to implement it safely, it 
> needs to do allocation.  I declared it VSIP_THROW((std::bad_alloc)).
Please file an issue for this in the tracker.

				-- Jules