Re: [vsipl++] [PATCH] Fir<> IPP cleanup

[Jules Bergmann <jules@xxxxxxxxxxxxxxxx>]

Nathan,

Nathan (Jasper) Myers wrote:
> I have checked in the patch below.
>
> Fir<> now uses IPP for types and modes it supports, and native C++
> code otherwise.  Before, if IPP was turned on it would only support
> types IPP supports -- e.g., not long double, or int.   It also 
> avoids exposing user code to Intel-header definitions.
> Nathan Myers
> ncm
>  
> -#include "ipp.hpp"
> +#include <vsip/impl/acconfig.hpp>
> +
> +#if defined(VSIP_IMPL_HAVE_IPP)
This file (ipp.cpp) is only compiled if VSIP_IMPL_HAVE_IPP is defined. 
Why is it necessary to add this guard?

> +
> +#include <vsip/math.hpp>
> +#include <vsip/signal.hpp>
Why does ipp.cpp need to include these?


> +#include <vsip/impl/ipp.hpp>
>  #include <ipps.h>

> -struct Ipp_fir_driver_base
> +template <typename T>
> +struct Fir_driver
>  {
> +  static const bool  reverse_kernel = true;
> +  static const bool  use_native = true;
> +  static const bool  mismatch_ok = true;
Can you document what 'mismatch_ok' means?


>    }
>  
>    // FIXME: spec says this should be nothrow, but it has to allocate
Please capture this fixme with an issue and then remove it.