Re: [vsipl++] [PATCH] Fir<> IPP cleanup

["Nathan (Jasper) Myers" <ncm@xxxxxxxxxxxxxxxx>]

On Thu, Oct 27, 2005 at 07:44:38AM -0400, Jules Bergmann wrote:
> >
> >Fir<> now uses IPP for types and modes it supports, and native C++
> >code otherwise.  Before, if IPP was turned on it would only support
> >types IPP supports -- e.g., not long double, or int.   It also 
> >avoids exposing user code to Intel-header definitions.
> 
> >-#include "ipp.hpp"
> >+#include <vsip/impl/acconfig.hpp>
> >+
> >+#if defined(VSIP_IMPL_HAVE_IPP)
> 
> This file (ipp.cpp) is only compiled if VSIP_IMPL_HAVE_IPP is defined. 
> Why is it necessary to add this guard?

I guess it's not...  OK, I have found src/vsip/GNUmakefile.inc.in.
Deleted #if and checked in.

> >+#include <vsip/math.hpp>
> >+#include <vsip/signal.hpp>
> 
> Why does ipp.cpp need to include these?

Because code I added to ipp.cpp depends on names defined in them.
Should ipp.cpp not depend on vsip headers?  Should there be a 
separate .cpp for that stuff?

> >+  static const bool  reverse_kernel = true;
> >+  static const bool  use_native = true;
> >+  static const bool  mismatch_ok = true;
> 
> Can you document what 'mismatch_ok' means?

OK, added and checked in. 

> >   // FIXME: spec says this should be nothrow, but it has to allocate
> 
> Please capture this fixme with an issue and then remove it.

The issue is already logged, so I just removed the comment.

Nathan Myers
ncm