Re: [vsipl++] [PATCH] Fir<> IPP cleanup

[Stefan Seefeld <stefan@xxxxxxxxxxxxxxxx>]

Nathan (Jasper) Myers wrote:
> On Thu, Oct 27, 2005 at 07:44:38AM -0400, Jules Bergmann wrote:

> > > +#include <vsip/math.hpp>
> > > +#include <vsip/signal.hpp>
> > Why does ipp.cpp need to include these?
>
> Because code I added to ipp.cpp depends on names defined in them.
> Should ipp.cpp not depend on vsip headers?  Should there be a 
> separate .cpp for that stuff?
Depending on how big the IPP<->VSIPL++ glue layer will become,
it may be best to replace the single ipp.cpp file with a whole
subdirectory where we can separate the code into source files
to make the code more readable and maintainable. It would allow
us not to have to sprinkle those VSIP_IMPL_HAVE_IPP macros all
over the code.
(And similarly for the other bindings such as SAL.)

> > > +  static const bool  reverse_kernel = true;
> > > +  static const bool  use_native = true;
> > > +  static const bool  mismatch_ok = true;
> > Can you document what 'mismatch_ok' means?
>
> OK, added and checked in. 
All comments meant to be documentation should be prefixed with a
triple slash ('///'). Normal comments will be filtered out in
the document extraction.

Regards,
		Stefan