Re: [vsipl++] [PATCH] Fir<> IPP cleanup

[Jules Bergmann <jules@xxxxxxxxxxxxxxxx>]

Nathan (Jasper) Myers wrote:

> > > +#include <vsip/math.hpp>
> > > +#include <vsip/signal.hpp>
> > Why does ipp.cpp need to include these?
>
> Because code I added to ipp.cpp depends on names defined in them.
> Should ipp.cpp not depend on vsip headers?  Should there be a 
> separate .cpp for that stuff?
That's not strictly necessary, but it is a good idea to minimize 
unnecessary dependencies.  It looks like ipp.cpp only depends on 
Ipp_fir_driver from signal-fir.hpp.  If you moved that into a separate 
header, or into ipp.hpp, you wouldn't need to include everything else.