Re: [vsipl++] [patch] SAL dispatch for matrix and vector products

[Don McCoy <don@xxxxxxxxxxxxxxxx>]

Jules Bergmann wrote:

> > I added SAL_USE_MAT_MUL for use in selecting the newer functions.
> This should start with VSIP_IMPL, i.e. VSIP_IMPL_SAL_USE_MAT_MUL
Fixed.  Committed.

> >  The default (0) selects the old ones.  It is tempting to make this a 
> > configuration option, but i really don't anticipate changing this 
> > switch back and forth.  I'm sure we'll just change it to a 1 when 
> > Mercury indicates it is a good time to do so.
>
> That's a good idea.  It's possible that people will want to use our 
> library with older versions of SAL.  After checking this in, can you 
> add a configure option?
Ok.  I'll make it override the above -- i.e. configure can optionally 
set it and i'll add #ifndef ... to the code so that it still defaults to 
0.  If there is a alternate method that is preferred, please let me 
know.  Specifically, did you want it to be a mandatory option (when 
using SAL) so that the user is forced to select one or the other?

--
Don McCoy
CodeSourcery, LLC