Re: [vsipl++] [patch] SAL dispatch for matrix and vector products

[Jules Bergmann <jules@xxxxxxxxxxxxxxxx>]

Don McCoy wrote:
> Jules Bergmann wrote:
> > That's a good idea.  It's possible that people will want to use our 
> > library with older versions of SAL.  After checking this in, can you 
> > add a configure option?
> Ok.  I'll make it override the above -- i.e. configure can optionally 
> set it and i'll add #ifndef ... to the code so that it still defaults to 
> 0.  If there is a alternate method that is preferred, please let me 
> know.
If you put something like:

	AC_ARG_ENABLE ... to set sal_use_mat_mul

	if test "$sal_use_mat_mul" = "yes"; then
	  AC_DEFINE_UNQUOTED(VSIP_IMPL_SAL_USE_MAT_MUL, 1,
	     [Define to use the new SAL mat_mul functions.])
        fi

in configure.ac,

then acconfig.hpp will have either (if sal_use_mat_mul != yes):

	/* #undef VSIP_IMPL_SAL_USE_MAT_MUL */

or (if sal_use_mat_mul == yes):

	#define VSIP_IMPL_SAL_USE_MAT_MUL

Then you shouldn't need to optionally set it, i.e. your '#if 
VSIP_IMPL_SAL_USE_MAT_MUL' will treat VSIP_IMPL_SAL_USE_MAT_MUL the same 
whether it is 0 or undefined.
> Specifically, did you want it to be a mandatory option (when 
> using SAL) so that the user is forced to select one or the other?
No, it doesn't need to be mandatory.  Probably the default should be to 
not use mat_mul.
				-- Jules