[ Date Prev][ Date Next][ Thread Prev][ Thread Next][ Date Index][ Thread Index]
Re: [vsipl++] PATCH: installation / packaging
- To: Stefan Seefeld <stefan@xxxxxxxxxxxxxxxx>
- Subject: Re: [vsipl++] PATCH: installation / packaging
- From: Mark Mitchell <mark@xxxxxxxxxxxxxxxx>
- Date: Tue, 03 Jan 2006 20:57:25 -0800
Stefan Seefeld wrote:
> The appended patch adds or completes the following targets:
Wow, very cool.
> ########################################################################
> +# Variables
> +########################################################################
I would still call this "Internal Variables", just to be a little clearer.
> +# Call this target explicitely to copy documentation back into the
explicitly
> +# source directory.
> +ifneq '$(srcdir)' '.'
Would "ifneq $(srcdir) $(objdir)" be clearer and/or more robust?
Other than that, it looks great to me.
--
Mark Mitchell
CodeSourcery
mark@xxxxxxxxxxxxxxxx
(650) 331-3385 x713
|
