Re: [vsipl++] clapack

[Jules Bergmann <jules@xxxxxxxxxxxxxxxx>]

Assem,

Assem Salama wrote:
> Index: SRC/f2c.h
> ===================================================================
> RCS file: /home/cvs/Repository/clapack/SRC/f2c.h,v
> retrieving revision 1.1
> retrieving revision 1.2
> diff -u -r1.1 -r1.2
> --- SRC/f2c.h	16 Mar 2006 23:11:40 -0000	1.1
> +++ SRC/f2c.h	21 Mar 2006 13:23:25 -0000	1.2
> @@ -7,7 +7,9 @@
>  #ifndef F2C_INCLUDE
>  #define F2C_INCLUDE
>  
> -typedef long int integer;
A more descriptive comment here would be good.  Something like:

// The original clapack header defined 'integer' to be a 'long int'.
// This creates a problem on 64-bit architectures, in particular the
// em64t, because 'long int' is 64-bits, while a FORTRAN 'integer' is
// only 32-bits.  This causes programs compiled for use with the FORTRAN
// lapack to not work properly with clapack.
//
// Defining 'integer' to be an 'int' fixes this problem.
typedef int integer;

Also, no need to leave the old typedef around in commented out form.  If 
necessary we can use CVS to see the old version.
> +// Assem: we don't want integer to be 64 bits!!
> +//typedef long int integer;
> +typedef int integer;
>  typedef unsigned long uinteger;
>  typedef char *address;
>  typedef short int shortint;
> Index: GNUmakefile.inc.in
> ===================================================================
> RCS file: /home/cvs/Repository/vpp/vendor/GNUmakefile.inc.in,v
Changes to this file look good.

				-- Jules


--
Jules Bergmann
CodeSourcery
jules@xxxxxxxxxxxxxxxx
(650) 331-3385 x705