Re: [vsipl++] [patch] fix for MPI type define

[Jules Bergmann <jules@xxxxxxxxxxxxxxxx>]

Don McCoy wrote:
> This patch corrects a minor typo related to the location of the mpi.h 
> header file.
> Ok to commit?
Don,

Looks good, please check it in.  Can you mention the macro name in the 
ChangeLog?  Thanks for catching this.
The obvious response is to wonder how this ever worked.  IIRC we used to 
create a pound-define with the MPI header name, i.e.
	#define VSIP_IMPL_MPI_H <mpi/mpi.h>

and would then include it

	#include VSIP_IMPL_MPI_H

However, this did not work with Intel C++.  The fix was to use 
VSIP_IMPL_MPI_H_TYPE, but apparently we did not test the mpi/mpi.h case 
after making the change!
				-- Jules

> ------------------------------------------------------------------------
>
> Index: ChangeLog
> ===================================================================
> --- ChangeLog	(revision 174589)
> +++ ChangeLog	(working copy)
> @@ -1,3 +1,8 @@
> +2007-06-20  Don McCoy  <don@xxxxxxxxxxxxxxxx>
> +
> +	* src/vsip/core/mpi/services.hpp: Fix typo for systems having
> +	  their MPI header files in the mpi/ subdirectory.
Can you mention the macro name:

	* src/vsip/core/mpi/services.hpp (VSIP_IMPL_MPI_H_TYPE): ...



--
Jules Bergmann
CodeSourcery
jules@xxxxxxxxxxxxxxxx
(650) 331-3385 x705