Re: [vsipl++] [patch] Fftm diagnostics, misc cleanup & FFTW fix for powerpc-eabi

[Stefan Seefeld <stefan@xxxxxxxxxxxxxxxx>]

Jules Bergmann wrote:
> These patches:
>  - Add Fftm diagnostics

> @@ -192,6 +212,32 @@
>    }
>  };
>  
> +
> +
> +struct Diagnose_fftm
> +{
> +  template <typename FftmT>
> +  static void diag(std::string name, FftmT const& fftm)
I believe it would be better to pass 'name' by (const) reference. I 
don't think std::string is mandated to be implemented with copy-on-write 
semantics. (There are other similar cases.)

>  - Cleanup vendor libs from lib/ directory
> @@ -143,6 +146,7 @@
>  	rm -f vendor/atlas/lib/libcblas.a lib/libcblas.a
>  	rm -f $(vendor_MERGED_LAPACK) lib/liblapack.a
>  	rm -f $(vendor_PRE_LAPACK)
> +	rm -f lib/libcblas.a lib/libatlas.a lib/liblapack.a
I believe only the lib/libatlas.a was missing above.

>  - Fix fft and fftm benchmarks to compile when double-precision
>    FFTs aren't supported
>  - Add hook to FFTW3 to work around unimplemented gettimeofday/clock
>    functions in the windows powerpc-eabi simulator.
>
> Ok to apply?
Looks good, modulo the above two points.

Thanks,
		Stefan

--
Stefan Seefeld
CodeSourcery
stefan@xxxxxxxxxxxxxxxx
(650) 331-3385 x718