Re: [vsipl++] [patch] Fftm diagnostics, misc cleanup & FFTW fix for powerpc-eabi

[Jules Bergmann <jules@xxxxxxxxxxxxxxxx>]

> > +{
> > +  template <typename FftmT>
> > +  static void diag(std::string name, FftmT const& fftm)
> I believe it would be better to pass 'name' by (const) reference. I 
> don't think std::string is mandated to be implemented with copy-on-write 
> semantics. (There are other similar cases.)
Good suggestion.  I fixed the other cases in diag/fft.cpp too.

> >  - Cleanup vendor libs from lib/ directory
> > @@ -143,6 +146,7 @@
> >      rm -f vendor/atlas/lib/libcblas.a lib/libcblas.a
> >      rm -f $(vendor_MERGED_LAPACK) lib/liblapack.a
> >      rm -f $(vendor_PRE_LAPACK)
> > +    rm -f lib/libcblas.a lib/libatlas.a lib/liblapack.a
> I believe only the lib/libatlas.a was missing above.
Oops, none of the additions were necessary for this case!  (a little 
more context would show that libatlas is deleted too).
Applied with those suggestions.

				thanks,
				-- Jules

--
Jules Bergmann
CodeSourcery
jules@xxxxxxxxxxxxxxxx
(650) 331-3385 x705