Actions

icon Post
text/html Subscribe
text/html Unsubscribe

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [vsipl++] [patch] Share ALF w/CML; Fix vmul_c kernel


  • To: Stefan Seefeld <stefan@xxxxxxxxxxxxxxxx>
  • Subject: Re: [vsipl++] [patch] Share ALF w/CML; Fix vmul_c kernel
  • From: Jules Bergmann <jules@xxxxxxxxxxxxxxxx>
  • Date: Wed, 14 May 2008 09:25:11 -0400



Shouldn't we pass the 'num_accelerators' argument down to cml_init() ? Otherwise there is no way to mandate how many SPUs to use from SV++. Or am I missing something ?

Yes definitely!  I was thinking of a FIXME to that effect.



 -include src/vsip/opt/cbe/alf/src/spu/GNUmakefile.inc

I just noticed this inclusion, which I missed to remove in my previous patch. (The '-' at the beginning makes 'make' ignore the failure, so we didn't see it.) Can you please remove this line when you commit the patch ? The alf/ subdirectory doesn't exist any more.

Yes, will do.


--
Jules Bergmann
CodeSourcery
jules@xxxxxxxxxxxxxxxx
(650) 331-3385 x705