Re: [vsipl++] [patch] Kernel updates

[Stefan Seefeld <stefan@xxxxxxxxxxxxxxxx>]

Jules Bergmann wrote:
> This patch updates the remaining VSIPL++ kernels to use ALF 3.0 and CML 
> where possible.  This removes the dependency on libfft_example from the 
> SDK, removes the specialized split FFT routines, and pushes twiddle 
> computation into the kernels.
> This also requires a minor CML patch, which I'll post separately.
>
> Ok to apply?
Jules,

I have a single (minor) issue:

> +	* src/vsip/opt/cbe/spu/alf_pwarp_ub.cpp: Move ALF decls to
> +	  alf_decl.hpp.  Add missing argument to kernel.
> +	* src/vsip/opt/ceb/spu/alf_decls.hpp: New file, decls for functions
> +	  expected by ALF.
I don't quite understand the purpose of this split. Do you propose we 
adhere to the convention of naming these functions always 'input', 
'output', and 'kernel' ? The only reason ALF expects those names is 
because you refer to them in the ALF_ACCEL_EXPORT_API macros, and it 
would have been enough to put an 'extern "C"' linkage spec in front of 
those function definitions, no matter how they are actually named.
The patch looks good otherwise.

Thanks,
		Stefan

--
Stefan Seefeld
CodeSourcery
stefan@xxxxxxxxxxxxxxxx
(650) 331-3385 x718