Re: [vsipl++] [patch] Kernel updates

[Jules Bergmann <jules@xxxxxxxxxxxxxxxx>]

Jules Bergmann wrote:
> Stefan,
>
> > I have a single (minor) issue:
> >
> > > +    * src/vsip/opt/cbe/spu/alf_pwarp_ub.cpp: Move ALF decls to
> > > +      alf_decl.hpp.  Add missing argument to kernel.
> > > +    * src/vsip/opt/ceb/spu/alf_decls.hpp: New file, decls for functions
> > > +      expected by ALF.
> > I don't quite understand the purpose of this split. Do you propose we 
> > adhere to the convention of naming these functions always 'input', 
> > 'output', and 'kernel' ? The only reason ALF expects those names is 
> > because you refer to them in the ALF_ACCEL_EXPORT_API macros, and it 
> > would have been enough to put an 'extern "C"' linkage spec in front of 
> > those function definitions, no matter how they are actually named.
> The main intent was to prevent the 23 lines of declaration having to be 
> replicated in every C++ kernel.  It does however require following a 
> naming convention for the routines.  I didn't see that as a bad thing 
> though.  Do you think it will create a problem?
My mistake, thanks for catching this!  I saw the forward decls and 
assumed they were necessary, but they weren't.  Changed as suggested, 
patch applied.
				-- Jules
--
Jules Bergmann
CodeSourcery
jules@xxxxxxxxxxxxxxxx
(650) 331-3385 x705