Re: [vsipl++] [patch] matrix-vector and vector-matrix product dispatch to CML

[Jules Bergmann <jules@xxxxxxxxxxxxxxxx>]

Don McCoy wrote:
> Don McCoy wrote:
> > This patch required adding a new pair of tests to the existing
> > matrix-vector product tests to cover cases of non-unit strides allowed
> > by CML.
> >
> >   
> Bindings for split-complex versions were omitted from the previous
> version of this patch. 
>
> Ok to commit now?
Don,

I have a couple of minor nit-picks below with unused typedefs, but
otherwise this looks good, please check it in.

				thanks,
				-- Jules


> +/// CML evaluator for matrix-vector products
> +
> +template <typename Block0,
> +          typename Block1,
> +          typename Block2>
> +struct Evaluator<Op_prod_mv, Block0, Op_list_2<Block1, Block2>,
> +                 Cml_tag>
> +{
> +  typedef typename Block0::value_type T;
> +  typedef typename Block_layout<Block0>::order_type order0_type;
> +  typedef typename Block_layout<Block1>::order_type order1_type;
> +  typedef typename Block_layout<Block2>::order_type order2_type;
order0_type and order2_type aren't used.



> +/// CML evaluator for vector-matrix products
> +
> +template <typename Block0,
> +          typename Block1,
> +          typename Block2>
> +struct Evaluator<Op_prod_vm, Block0, Op_list_2<Block1, Block2>,
> +                 Cml_tag>
> +{
> +  typedef typename Block0::value_type T;
> +  typedef typename Block_layout<Block0>::order_type order0_type;
> +  typedef typename Block_layout<Block1>::order_type order1_type;
> +  typedef typename Block_layout<Block2>::order_type order2_type;
order0_type and order1_type aren't used


--
Jules Bergmann
CodeSourcery
jules@xxxxxxxxxxxxxxxx
(650) 331-3385 x705