Actions

icon Post
text/html Subscribe
text/html Unsubscribe

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [vsipl++] patch: enable/disable fftwf, fftw, and fftwl individually


  • To: Jules Bergmann <jules@xxxxxxxxxxxxxxxx>
  • Subject: Re: [vsipl++] patch: enable/disable fftwf, fftw, and fftwl individually
  • From: Stefan Seefeld <stefan@xxxxxxxxxxxxxxxx>
  • Date: Sat, 31 May 2008 10:36:14 -0400

Jules Bergmann wrote:

* I fixed code (in configure.ac) that assumed its default value was '', not '0'.

Why change this?


The 'provide_...' macros have values of either '0' or '1', but never ''.
Thus, the original test:

 if test "x$provide_fft_long_double" != "x"; then

will always succeed. I don't mind whether we use 0/1 or ''/'something', but we should either test the real state or not test at all. So, the least disruptive change would be just to take out the test, as it is always true.

Thanks,
		Stefan


--
Stefan Seefeld
CodeSourcery
stefan@xxxxxxxxxxxxxxxx
(650) 331-3385 x718