Re: [vsipl++] patch: enable/disable fftwf, fftw, and fftwl individually

[Jules Bergmann <jules@xxxxxxxxxxxxxxxx>]

> The 'provide_...' macros have values of either '0' or '1', but never ''.
> Thus, the original test:
>
> >  if test "x$provide_fft_long_double" != "x"; then
> will always succeed. I don't mind whether we use 0/1 or ''/'something', 
> but we should either test the real state or not test at all. So, the 
> least disruptive change would be just to take out the test, as it is 
> always true.
Ok, sounds like we're on the same page.

I was less concerned with removing the check than with changing the 
definition of the macro.
Instead of

>  if test "$neutral_acconfig" = 'y'; then
> -  if test "x$provide_fft_float" != "x"; then
> -    CPPFLAGS="$CPPFLAGS -DVSIP_IMPL_PROVIDE_FFT_FLOAT=$provide_fft_float"
> +  if test $provide_fft_float != 0; then
> +    CPPFLAGS="$CPPFLAGS -DVSIP_IMPL_PROVIDE_FFT_FLOAT=1"
>    fi
How about

>  if test "$neutral_acconfig" = 'y'; then
> -  if test "x$provide_fft_float" != "x"; then
>      CPPFLAGS="$CPPFLAGS -DVSIP_IMPL_PROVIDE_FFT_FLOAT=$provide_fft_float"
> -  fi
With that, and some address of the sh portability question (such as 
telling me not to worry about it :), and the patch looks good.
					-- Jules


--
Jules Bergmann
CodeSourcery
jules@xxxxxxxxxxxxxxxx
(650) 331-3385 x705