Re: [vsipl++] [patch] Distributed transpose

[Stefan Seefeld <stefan@xxxxxxxxxxxxxxxx>]

Jules Bergmann wrote:
> This patch fixes handling of distributed transposes of the form:
>
>     A = B.transpose();
>
> Ok to apply?

Jules,

the patch looks good.

There were a couple of changes of the form:

> -/* Copyright (c) 2005 by CodeSourcery, LLC.  All rights reserved. */
> +/* Copyright (c) 2005, 2008 by CodeSourcery, LLC.  All rights reserved. */
>  
where I'd like to suggest we remove the obsolete 'LLC.', while applying 
other changes. (I don't think this is worth a full sweep over the sources !)
Also, this patch reminds me of two issues, which I hope we will find the 
time to address over the coming months:
* We need to address the many header interdependencies, in particular 
between the serial and the parallel set. There is some circularity that 
is very hard to break out of.
* There are sets of templates that form a self-contained block of 
functionality that I think is important to document, both, from a low 
level as well as middel-level view. I'm in particular thinking of the 
Combine_return_type logic (which I have run across multiple times this 
week already)

Thanks,
		Stefan

--
Stefan Seefeld
CodeSourcery
stefan@xxxxxxxxxxxxxxxx
(650) 331-3385 x718