Actions

icon Post
text/html Subscribe
text/html Unsubscribe

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [vsipl++] [patch] fix in SAL backend for outer product


  • To: Don McCoy <don@xxxxxxxxxxxxxxxx>
  • Subject: Re: [vsipl++] [patch] fix in SAL backend for outer product
  • From: Jules Bergmann <jules@xxxxxxxxxxxxxxxx>
  • Date: Wed, 11 Jun 2008 08:02:33 -0400

Don McCoy wrote:
This patch fixes a block dimension order check in the outer product
evaluator.  Note that this evaluator is only available when
VSIP_IMPL_SAL_USE_MAT_MUL is defined to something other than '0' (the
default).

As a result of the bug, the existing test coverage was missing the cases
where the output matrix was column-major in the smallest dimension. Now those cases are getting picked up and validated.

Ok to commit?

Don, Yes, this looks good, please check it in.  -- Jules

--
Jules Bergmann
CodeSourcery
jules@xxxxxxxxxxxxxxxx
(650) 331-3385 x705